linux-kernel - Re: [PATCH 5/8] media: vimc: stream: cleanup frame field from struct vimc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adbfa62c-e5f6-4c24-76b4-cac299cdd800@collabora.com>
Date:   Thu, 7 Mar 2019 17:19:15 -0300
From:   André Almeida <andrealmeid@...labora.com>
To:     Helen Koike <helen.koike@...labora.com>,
        linux-media@...r.kernel.org
Cc:     lucmaga@...il.com, linux-kernel@...r.kernel.org,
        lkcamp@...ts.libreplanetbr.org, Hans Verkuil <hverkuil@...all.nl>,
        kernel@...labora.com
Subject: Re: [PATCH 5/8] media: vimc: stream: cleanup frame field from struct
 vimc_stream

Hello,

I've tested the stream (with the default media bus format and using an 
alternative one) using a custom user space application and tested all 
capture entities using qv4l2 -d /dev/videoX (where X is each of the 
capture entities). Also, I have checked v4l2-compliance -d /dev/videoX 
and with v4l2-compliance --streaming=5 -d /dev/videoX and no regressions 
where found.

On 3/6/19 7:42 PM, Helen Koike wrote:
> There is no need to have the frame field in the vimc_stream struct.
>
> Signed-off-by: Helen Koike <helen.koike@...labora.com>
Tested-by: André Almeida <andre.almeida@...labora.com>
> ---
>
>   drivers/media/platform/vimc/vimc-streamer.c | 10 ++++------
>   drivers/media/platform/vimc/vimc-streamer.h |  1 -
>   2 files changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/media/platform/vimc/vimc-streamer.c b/drivers/media/platform/vimc/vimc-streamer.c
> index 392754c18046..b7c1fdef5f0d 100644
> --- a/drivers/media/platform/vimc/vimc-streamer.c
> +++ b/drivers/media/platform/vimc/vimc-streamer.c
> @@ -117,6 +117,7 @@ static int vimc_streamer_pipeline_init(struct vimc_stream *stream,
>   static int vimc_streamer_thread(void *data)
>   {
>   	struct vimc_stream *stream = data;
> +	u8 *frame = NULL;
>   	int i;
>   
>   	set_freezable();
> @@ -127,12 +128,9 @@ static int vimc_streamer_thread(void *data)
>   			break;
>   
>   		for (i = stream->pipe_size - 1; i >= 0; i--) {
> -			stream->frame = stream->ved_pipeline[i]->process_frame(
> -					stream->ved_pipeline[i],
> -					stream->frame);
> -			if (!stream->frame)
> -				break;
> -			if (IS_ERR(stream->frame))
> +			frame = stream->ved_pipeline[i]->process_frame(
> +					stream->ved_pipeline[i], frame);
> +			if (!frame || IS_ERR(frame))
>   				break;
>   		}
>   		//wait for 60hz
> diff --git a/drivers/media/platform/vimc/vimc-streamer.h b/drivers/media/platform/vimc/vimc-streamer.h
> index 752af2e2d5a2..dc1d0be431cb 100644
> --- a/drivers/media/platform/vimc/vimc-streamer.h
> +++ b/drivers/media/platform/vimc/vimc-streamer.h
> @@ -19,7 +19,6 @@ struct vimc_stream {
>   	struct media_pipeline pipe;
>   	struct vimc_ent_device *ved_pipeline[VIMC_STREAMER_PIPELINE_MAX_SIZE];
>   	unsigned int pipe_size;
> -	u8 *frame;
>   	struct task_struct *kthread;
>   };
>