linux-kernel - [PATCH] ath11k: fix bugon.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Mar 2019 22:48:53 +0100 (CET)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Venkateswara Naralasetty <vnaralas@...eaurora.org>
cc:     Kalle Valo <kvalo@...eaurora.org>, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        ath10k@...ts.infradead.org, kbuild-all@...org
Subject: [PATCH] ath11k: fix bugon.cocci warnings

From: kbuild test robot <lkp@...el.com>

Use BUG_ON instead of if condition followed by BUG.

Generated by: scripts/coccinelle/misc/bugon.cocci

Fixes: c105b7abf400 ("ath11k: collect DDR dump after fw crash")
CC: Venkateswara Naralasetty <vnaralas@...eaurora.org>
Signed-off-by: kbuild test robot <lkp@...el.com>
Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath11k-bringup
head:   e7daa3ec639f390e383dae0db9e6b143bcc7b5bc
commit: c105b7abf400972ee661efe18b4ca11adfd137cd [28/42] ath11k: collect DDR dump after fw crash
:::::: branch date: 5 hours ago
:::::: commit date: 5 hours ago

Please take the patch only if it's a positive warning. Thanks!

 ahb.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/net/wireless/ath/ath11k/ahb.c
+++ b/drivers/net/wireless/ath/ath11k/ahb.c
@@ -954,8 +954,7 @@ static int ath11k_subsys_notifier_cb(str
 		sc->target_restarted = 0;
 		break;
 	case SUBSYS_BEFORE_POWERUP:
-		if (sc->target_restarted)
-			BUG();
+		BUG_ON(sc->target_restarted);
 		break;
 	default:
 		return NOTIFY_OK;