linux-kernel - Re: [PATCH 1/3] x86: apuv2: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZmNbPcSQXU6mosQJk1j9k+vQfJbs2KUZcXTUo172_cCQ@mail.gmail.com>
Date:   Fri, 8 Mar 2019 10:11:37 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     "Enrico Weigelt, metux IT consult" <info@...ux.net>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        platform-driver-x86 <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] x86: apuv2: remove unused variable

On Mon, Mar 4, 2019 at 9:09 PM Arnd Bergmann <arnd@...db.de> wrote:

> The driver was newly introduced but the version that got merged
> produces a harmless compiler warning:
>
> drivers/platform/x86/pcengines-apuv2.c: In function 'apu_board_init':
> drivers/platform/x86/pcengines-apuv2.c:211:6: error: unused variable 'rc' [-Werror=unused-variable]
>
> Remove the evidently useless variable.
>
> Fixes: f8eb0235f659 ("x86: pcengines apuv2 gpio/leds/keys platform driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

As Torvalds did not yet pull the GPIO tree (maybe because of this
and other bugs, who knows) I applied this to my GPIO tree for
now.

Yours,
Linus Walleij