linux-kernel - Re: [PATCH v2 2/3] dt-bindings: mmc: Add a new property disable-cqe-dcmd.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <37a96eda-196e-bacf-7ae2-5b9354c70273@intel.com>
Date:   Fri, 8 Mar 2019 14:46:47 +0200
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Christoph Muellner <christoph.muellner@...obroma-systems.com>,
        robh+dt@...nel.org, mark.rutland@....com, heiko@...ech.de,
        shawn.lin@...k-chips.com, ulf.hansson@...aro.org
Cc:     Philipp Tomsich <philipp.tomsich@...obroma-systems.com>,
        Michal Simek <michal.simek@...inx.com>,
        Douglas Anderson <dianders@...omium.org>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Vicente Bergas <vicencb@...il.com>,
        Emil Renner Berthing <kernel@...il.dk>,
        Randy Li <ayaka@...lik.info>,
        Tony Xie <tony.xie@...k-chips.com>,
        Ezequiel Garcia <ezequiel@...labora.com>,
        Klaus Goger <klaus.goger@...obroma-systems.com>,
        Lin Huang <hl@...k-chips.com>, linux-mmc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v2 2/3] dt-bindings: mmc: Add a new property
 disable-cqe-dcmd.

On 7/03/19 10:43 AM, Christoph Muellner wrote:
> This patch documents the new property disable-cqe-dcmd
> for the Arasan eMMC 5.1 driver.
> 
> Signed-off-by: Christoph Muellner <christoph.muellner@...obroma-systems.com>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@...obroma-systems.com>
> ---
>  Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> index 1edbb049cccb..ec699bf98b7c 100644
> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> @@ -44,6 +44,10 @@ Optional Properties:
>      properly. Test mode can be used to force the controller to function.
>    - xlnx,int-clock-stable-broken: when present, the controller always reports
>      that the internal clock is stable even when it is not.
> +  - disable-cqe-dcmd: The eMMC 5.1 standard specifies direct commands (DCMDs)
> +    as part of the command queue engine (CQE). On controllers with a CQHCI,
> +    such as the Arasan eMMC 5.1 host controller, the driver has to enable DCMDs.
> +    This is done unless disable-cqe-dcmd is specified.

If "supports-cqe" is in mmc.txt, should "disable-cqe-dcmd" be there also?