linux-kernel - RE: [PATCH V7 1/3] watchdog: imx_sc: Add i.MX system controller watchdog support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM0PR04MB4211321FEC8827FD105F7028804D0@AM0PR04MB4211.eurprd04.prod.outlook.com>
Date:   Fri, 8 Mar 2019 02:25:48 +0000
From:   Aisheng Dong <aisheng.dong@....com>
To:     Anson Huang <anson.huang@....com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "will.deacon@....com" <will.deacon@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "wim@...ux-watchdog.org" <wim@...ux-watchdog.org>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        Andy Gross <andy.gross@...aro.org>,
        "heiko@...ech.de" <heiko@...ech.de>,
        "horms+renesas@...ge.net.au" <horms+renesas@...ge.net.au>,
        "arnd@...db.de" <arnd@...db.de>,
        "maxime.ripard@...tlin.com" <maxime.ripard@...tlin.com>,
        "jagan@...rulasolutions.com" <jagan@...rulasolutions.com>,
        "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
        "enric.balletbo@...labora.com" <enric.balletbo@...labora.com>,
        "marc.w.gonzalez@...e.fr" <marc.w.gonzalez@...e.fr>,
        "olof@...om.net" <olof@...om.net>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>
CC:     dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH V7 1/3] watchdog: imx_sc: Add i.MX system controller
 watchdog support

[...]

> >
> > > > As I replied in another mail, it actually does not depend on SCU.
> > > > Let's wait for Rob's comment on whether we could move watchdog Out
> > > > of SCU node.
> > >
> > > Per previous discussion, the dependency here is to prevent enabling
> > > this module for platform without IMX SCU, although it does NOT use
> > > SCU IPC call, but the SMC call trap into ARM-Trusted-Firmware will
> > > eventually call SCU API, so it still depends on IMX SCU hardware, I
> > > am NOT very sure if it is correct to remove it here.
> > >
> >
> > Then it's ATF depends on SCU, not this virtual watchdog based on ARM
> > SIP, right?
> 
> But we don't have ATF driver in Linux kernel..., I am confused, anyway, if
> Guenter agrees, I can remove this dependency here.
> 

So far the only thing that watchdog depends on SCU driver is that it needs
SCU driver to create a platform devices for it.
We need wait Rob's feedback, if he agree moved the watchdog node
Out of SCU, we can remove this dependency.

Regards
Dong Aisheng

> Anson.
> 
> >
> > Regards
> > Dong Aisheng
> >
> > > >
> > > > > +	depends on HAVE_ARM_SMCCC
> > > > > +	select WATCHDOG_CORE
> > > > > +	help
> > > > > +	  This is the driver for the system controller watchdog
> > > > > +	  on the NXP i.MX SoCs with system controller inside.
> > > > > +	  If you have one of these processors and wish to have
> > > > > +	  watchdog support enabled, say Y, otherwise say N.
> > > > > +