linux-kernel - Re: [PATCH] kasan: fix coccinelle warnings in kasan_p*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 8 Mar 2019 08:33:31 +0530
From:   Souptick Joarder <jrdr.linux@...il.com>
To:     Andrey Ryabinin <aryabinin@...tuozzo.com>
Cc:     Andrey Konovalov <andreyknvl@...gle.com>,
        Alexander Potapenko <glider@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>, kasan-dev@...glegroups.com,
        Linux-MM <linux-mm@...ck.org>, linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Kostya Serebryany <kcc@...gle.com>,
        kbuild test robot <lkp@...el.com>
Subject: Re: [PATCH] kasan: fix coccinelle warnings in kasan_p*_table

On Tue, Mar 5, 2019 at 9:43 PM Andrey Ryabinin <aryabinin@...tuozzo.com> wrote:
>
>
>
> On 3/4/19 8:04 PM, Andrey Konovalov wrote:
> > kasan_p4d_table, kasan_pmd_table and kasan_pud_table are declared as
> > returning bool, but return 0 instead of false, which produces a coccinelle
> > warning. Fix it.
> >
> > Fixes: 0207df4fa1a8 ("kernel/memremap, kasan: make ZONE_DEVICE with work with KASAN")
> > Reported-by: kbuild test robot <lkp@...el.com>
> > Signed-off-by: Andrey Konovalov <andreyknvl@...gle.com>
> > ---
>
> Acked-by: Andrey Ryabinin <aryabinin@...tuozzo.com>
>
>
> >  mm/kasan/init.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/mm/kasan/init.c b/mm/kasan/init.c
> > index 45a1b5e38e1e..fcaa1ca03175 100644
> > --- a/mm/kasan/init.c
> > +++ b/mm/kasan/init.c
> > @@ -42,7 +42,7 @@ static inline bool kasan_p4d_table(pgd_t pgd)
> >  #else
> >  static inline bool kasan_p4d_table(pgd_t pgd)
> >  {
> > -     return 0;
> > +     return false;
> >  }
> >  #endif
> >  #if CONFIG_PGTABLE_LEVELS > 3
> > @@ -54,7 +54,7 @@ static inline bool kasan_pud_table(p4d_t p4d)
> >  #else
> >  static inline bool kasan_pud_table(p4d_t p4d)
> >  {
> > -     return 0;
> > +     return false;
> >  }
> >  #endif
> >  #if CONFIG_PGTABLE_LEVELS > 2
> > @@ -66,7 +66,7 @@ static inline bool kasan_pmd_table(pud_t pud)
> >  #else
> >  static inline bool kasan_pmd_table(pud_t pud)
> >  {
> > -     return 0;
> > +     return false;
> >  }
> >  #endif
> >  pte_t kasan_early_shadow_pte[PTRS_PER_PTE] __page_aligned_bss;
> >
>

Acked-by: Souptick Joarder <jrdr.linux@...il.com>