linux-kernel - Re: [PATCH 15/20] objtool: Add --backtrace support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190308193305.ccivol3axwvcuc5p@treble>
Date:   Fri, 8 Mar 2019 13:33:05 -0600
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     torvalds@...ux-foundation.org, tglx@...utronix.de, hpa@...or.com,
        julien.thierry@....com, will.deacon@....com, luto@...capital.net,
        mingo@...nel.org, catalin.marinas@....com, james.morse@....com,
        valentin.schneider@....com, brgerst@...il.com, luto@...nel.org,
        bp@...en8.de, dvlasenk@...hat.com, linux-kernel@...r.kernel.org,
        dvyukov@...gle.com, rostedt@...dmis.org
Subject: Re: [PATCH 15/20] objtool: Add --backtrace support

On Thu, Mar 07, 2019 at 12:45:26PM +0100, Peter Zijlstra wrote:
> For when you want to know the path that reached your fail state.
> 
> $ ./objtool check --no-fp --backtrace arch/x86/lib/usercopy_64.o
> arch/x86/lib/usercopy_64.o: warning: objtool: .altinstr_replacement+0x3: UACCESS disable without MEMOPs: __clear_user()
> arch/x86/lib/usercopy_64.o: warning: objtool:   __clear_user()+0x3a: (alt)
> arch/x86/lib/usercopy_64.o: warning: objtool:   __clear_user()+0x2e: (branch)
> arch/x86/lib/usercopy_64.o: warning: objtool:   __clear_user()+0x18: (branch)
> arch/x86/lib/usercopy_64.o: warning: objtool:   .altinstr_replacement+0xffffffffffffffff: (branch)
> arch/x86/lib/usercopy_64.o: warning: objtool:   __clear_user()+0x5: (alt)
> arch/x86/lib/usercopy_64.o: warning: objtool:   __clear_user()+0x0: <=== (func)

We should have done this a long time ago.  Thank you for this!

-- 
Josh