linux-kernel - Re: [PATCH 12/20] objtool: Set insn->func for alternatives

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190308195141.GF32494@hirez.programming.kicks-ass.net>
Date:   Fri, 8 Mar 2019 20:51:41 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     torvalds@...ux-foundation.org, tglx@...utronix.de, hpa@...or.com,
        julien.thierry@....com, will.deacon@....com, luto@...capital.net,
        mingo@...nel.org, catalin.marinas@....com, james.morse@....com,
        valentin.schneider@....com, brgerst@...il.com, luto@...nel.org,
        bp@...en8.de, dvlasenk@...hat.com, linux-kernel@...r.kernel.org,
        dvyukov@...gle.com, rostedt@...dmis.org
Subject: Re: [PATCH 12/20] objtool: Set insn->func for alternatives

On Fri, Mar 08, 2019 at 01:16:29PM -0600, Josh Poimboeuf wrote:
> On Thu, Mar 07, 2019 at 12:45:23PM +0100, Peter Zijlstra wrote:
> > Make sure we set the function association for alternative instruction
> > sequences; they are after all still part of the function.
> 
> Can you also say _why_?  I presume it's so the warning messages will be
> saner.

Right; because I'll introduce function attributes later on, so it
becomes important to know what function an instruction belongs to.

I'll update the Changelog.

> > Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> > ---
> >  tools/objtool/check.c |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > --- a/tools/objtool/check.c
> > +++ b/tools/objtool/check.c
> > @@ -695,6 +695,7 @@ static int handle_group_alt(struct objto
> >  		last_new_insn = insn;
> >  
> >  		insn->ignore = orig_insn->ignore_alts;
> > +		insn->func = orig_insn->func;
> >  
> >  		if (insn->type != INSN_JUMP_CONDITIONAL &&
> >  		    insn->type != INSN_JUMP_UNCONDITIONAL)
> > 
> > 
> 
> -- 
> Josh