linux-kernel - Re: [PATCH 16/20] objtool: Rewrite alt->skip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190308213418.GF2482@worktop.programming.kicks-ass.net>
Date:   Fri, 8 Mar 2019 22:34:18 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     torvalds@...ux-foundation.org, tglx@...utronix.de, hpa@...or.com,
        julien.thierry@....com, will.deacon@....com, luto@...capital.net,
        mingo@...nel.org, catalin.marinas@....com, james.morse@....com,
        valentin.schneider@....com, brgerst@...il.com, luto@...nel.org,
        bp@...en8.de, dvlasenk@...hat.com, linux-kernel@...r.kernel.org,
        dvyukov@...gle.com, rostedt@...dmis.org
Subject: Re: [PATCH 16/20] objtool: Rewrite alt->skip_orig

On Fri, Mar 08, 2019 at 02:15:56PM -0600, Josh Poimboeuf wrote:
> On Thu, Mar 07, 2019 at 12:45:27PM +0100, Peter Zijlstra wrote:
> > Really skip the original instruction flow, instead of letting it
> > continue with NOPs.
> > 
> > Since the alternative code flow already continues after the original
> > instructions, only the alt-original is skipped.
> 
> I like this approach.  I wonder if we can do something similar to get
> rid of the nasty fake jumps.

This actually hard relies on those fake jumps. Or am I missing the
point?