linux-kernel - Re: [PATCH] platform/chrome: Add Wilco EC keyboard backlight LEDs support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE_wzQ-Ds5a9iPuLTpV5mBHBtoUUh_-fRw66s0Su7eOifygqKQ@mail.gmail.com>
Date:   Fri, 8 Mar 2019 14:01:07 -0800
From:   Dmitry Torokhov <dtor@...omium.org>
To:     Nick Crews <ncrews@...omium.org>
Cc:     enric.balletbo@...labora.com, Benson Leung <bleung@...omium.org>,
        linux-leds@...r.kernel.org, jacek.anaszewski@...il.com,
        Pavel Machek <pavel@....cz>,
        lkml <linux-kernel@...r.kernel.org>, dlaurie@...omium.org,
        Daniel Erat <derat@...gle.com>,
        Guenter Roeck <groeck@...gle.com>
Subject: Re: [PATCH] platform/chrome: Add Wilco EC keyboard backlight LEDs support

On Fri, Mar 8, 2019 at 12:41 PM Nick Crews <ncrews@...omium.org> wrote:
>
> This patch is meant to be applied on top of the for-next
> branch of the platform/chrome repository, as it uses some of
> the code staged there.
>
> The EC is in charge of controlling the keyboard backlight on
> the Wilco platform. We expose a standard LED class device at
> /sys/class/leds/wilco::kbd_backlight. This driver is modeled
> after the standard Chrome OS keyboard backlight driver at
> drivers/platform/chrome/cros_kbd_led_backlight.c
>
> Some Wilco devices do not support a keyboard backlight. This
> is checked in probe(), and in this case the sysfs entry will
> not appear, and everything will behave normally.

It would be even better if we did not register platform device if EC
does not support backlight.

> +       data->led.brightness_set = keyboard_led_set_brightness;
> +       data->led.brightness_get = keyboard_led_get_brightness;

wilco_ec_mailbox() may sleep, so you need to assign it to
led.brightness_set_blocking.

Thanks,
Dmitry