linux-kernel - Re: [PATCH v2] iio: proximity: as3935: fix use-after-free on device remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGngYiWSaJqtzUA+nUNJTcssUq1Y=UzYc2u8hDcKDjF6944o1Q@mail.gmail.com>
Date:   Fri, 8 Mar 2019 17:46:24 -0500
From:   Sven Van Asbroeck <thesven73@...il.com>
To:     Tomasz Duszynski <tduszyns@...il.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Jonathan Cameron <jonathan.cameron@...wei.com>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-iio@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Matt Ranostay <matt.ranostay@...sulko.com>
Subject: Re: [PATCH v2] iio: proximity: as3935: fix use-after-free on device remove

On Fri, Mar 8, 2019 at 5:33 PM Tomasz Duszynski <tduszyns@...il.com> wrote:
>
>
> So perhaps that change deserves a separate patch because it smells like
> a code cleanup.

Not really. This patch fixes the order in which resources are torn
down on release().
You do this by fixing the order by which devm-resources are allocated
on probe().

So it's a fundamental use-after-free fix, and not really a cleanup.
But I'm happy to split into multiple patches if you want ?