linux-kernel - Re: FS-Cache: Duplicate cookie detected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.999.1903081506320.21644@trent.utfs.org>
Date:   Fri, 8 Mar 2019 15:15:14 -0800 (PST)
From:   Christian Kujau <lists@...dbynature.de>
To:     David Howells <dhowells@...hat.com>
cc:     linux-kernel@...r.kernel.org,
        Anna Schumaker <anna.schumaker@...app.com>,
        Steve Dickson <steved@...hat.com>
Subject: Re: FS-Cache: Duplicate cookie detected

On Fri, 8 Mar 2019, David Howells wrote:
> See the attached for a patch that helps with certain kinds of collision,
> though I can't see that it should help with what you're seeing since the
> RELINQUISHED flag isn't set on the old cookie (fl=222, but 0x10 isn't in
> there).  You can monitor the number of waits by looking in
> /proc/fs/fscache/stats for the:
> 
> 	Acquire: n=289166 nul=0 noc=0 ok=286331 nbf=2 oom=0 wrq=23748

Running Linux v5.0 with this patch applied does indeed still produce the 
"Duplicate cookie detected" messages, but I only ever see wrq=0 when 
running nfstest_cache: 

   https://paste.fedoraproject.org/paste/dkav0FQzYZxE9-V7GphjAQ

(Scroll down until the messages start to appear again)

Only the n= field seems to change during that test:


fedora0# grep wrq n2.log  | sort | uniq -c | sort -n
     28 Acquire: n=8 nul=0 noc=0 ok=1 nbf=0 oom=0 wrq=0
     29 Acquire: n=7 nul=0 noc=0 ok=1 nbf=0 oom=0 wrq=0
     34 Acquire: n=6 nul=0 noc=0 ok=1 nbf=0 oom=0 wrq=0
     82 Acquire: n=9 nul=0 noc=0 ok=1 nbf=0 oom=0 wrq=0
     93 Acquire: n=5 nul=0 noc=0 ok=1 nbf=0 oom=0 wrq=0

HTH,
Christian.
-- 
BOFH excuse #5:

static from plastic slide rules