linux-kernel - Re: [PATCH v2] i2c: cadence: try reset when master receive arbitration lost

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190309094452.GB1340@kunai>
Date:   Sat, 9 Mar 2019 10:44:52 +0100
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Shikai Wang <sxauwsk@....com>
Cc:     Michal Simek <michal.simek@...inx.com>,
        Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>,
        linux-arm-kernel@...ts.infradead.org, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] i2c: cadence: try reset when master receive
 arbitration lost

On Sat, Feb 23, 2019 at 10:48:43AM +0100, Wolfram Sang wrote:
> On Tue, Feb 19, 2019 at 09:24:47AM +0800, Shikai Wang wrote:
> > When the adapter receive arbitration lost error interrupts,
> > cdns_i2c_master_xfer return to the caller directly instead of resetting
> > the adapter which resulted in the adapter being out of control.
> > 
> > So when driver detect err_status such as arbitration lost,
> > then try to repair and fix it.
> 
> Just checking because resetting looks like a big hammer to me: there is
> no way to gracefully recover form 'arbitration lost' interrupt?

I am still wondering about this but since it is acked by the maintainer:

Applied to for-current, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)