lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 9 Mar 2019 18:16:49 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Robert Yang <decatf@...il.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>, linux-iio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] iio: accel: kxcjk1013: Add device tree support

On Mon,  4 Mar 2019 10:19:12 -0500
Robert Yang <decatf@...il.com> wrote:

> Add device tree support for kxcjk-1013 accelerometer sensors.
> 
> Signed-off-by: Robert Yang <decatf@...il.com>
One comment below. 

Applied with that minor tweak to the togreg branch of iio.git
and pushed out as testing for the autobuilders to play with it.

Thanks,

Jonathan

> ---
>  drivers/iio/accel/kxcjk-1013.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
> index 7096e577b23f..e4cbc443e6ed 100644
> --- a/drivers/iio/accel/kxcjk-1013.c
> +++ b/drivers/iio/accel/kxcjk-1013.c
> @@ -1510,10 +1510,20 @@ static const struct i2c_device_id kxcjk1013_id[] = {
>  
>  MODULE_DEVICE_TABLE(i2c, kxcjk1013_id);
>  
> +static const struct of_device_id kxcjk1013_of_match[] = {
> +	{ .compatible = "kionix,kxcjk1013", },
> +	{ .compatible = "kionix,kxcj91008", },
> +	{ .compatible = "kionix,kxtj21009", },
> +	{ .compatible = "kionix,kxtf9", },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, kxcjk1013_of_match);
> +
>  static struct i2c_driver kxcjk1013_driver = {
>  	.driver = {
>  		.name	= KXCJK1013_DRV_NAME,
>  		.acpi_match_table = ACPI_PTR(kx_acpi_match),
> +		.of_match_table = of_match_ptr(kxcjk1013_of_match),
Sorry. I'd missed this before, but general preference is to not
use of_match_table any more because it stops people using the
somewhat odd ACPI object that lets you used dt bindings
via ACPI.

I'll drop it.

>  		.pm	= &kxcjk1013_pm_ops,
>  	},
>  	.probe		= kxcjk1013_probe,

Powered by blists - more mailing lists