linux-kernel - Re: [PATCH] iio: proximity: as3935: fix use-after-free on device remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190309182449.45cd1b28@archlinux>
Date:   Sat, 9 Mar 2019 18:24:49 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Sven Van Asbroeck <thesven73@...il.com>
Cc:     Jonathan Cameron <jonathan.cameron@...wei.com>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-iio@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Matt Ranostay <matt.ranostay@...sulko.com>
Subject: Re: [PATCH] iio: proximity: as3935: fix use-after-free on device
 remove

On Fri, 8 Mar 2019 12:49:30 -0500
Sven Van Asbroeck <thesven73@...il.com> wrote:

> On Fri, Mar 8, 2019 at 12:13 PM Jonathan Cameron
> <jonathan.cameron@...wei.com> wrote:
> >
> > Your description makes it clear that there are multiple things in the patch.
> > Don't do a 'while we were here' in a patch doing something else please.
> > Separate patches.
> >  
> 
> The proposed solution (adding devm_) fixes multiple issues, so that can stay
> as a single patch, right?
> 
> It's the 'while we're here' you'd like to see removed? Can do.

That's the one. Just the & removal.  The rest makes sense in
one patch as you say.

Jonathan