linux-kernel - Re: [PATCH v2 2/4] iio:potentiostat:lmp91000: reduce line width and remove blank line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190309184529.19cd4a05@archlinux>
Date:   Sat, 9 Mar 2019 18:45:29 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Anderson Reis <andersonreisrosa@...il.com>
Cc:     knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
        matt.ranostay@...sulko.com, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-usp@...glegroups.com,
        Anderson Reis <anderson.reis.rosa@....com>,
        Lucas Oshiro <lucasseikioshiro@...il.com>
Subject: Re: [PATCH v2 2/4] iio:potentiostat:lmp91000: reduce line width and
 remove blank line

On Fri,  8 Mar 2019 16:46:53 -0300
Anderson Reis <andersonreisrosa@...il.com> wrote:

> Break the line 258 in order fit the line width on 80 characters. Remove
> the blank line 279, as the line before is also a blank line. Solve these
> checkpath.el WARNING and CHECK:
> 
> - lmp91000.c:258: WARNING: line over 80 characters
> - lmp91000.c:279: CHECK: Please don't use multiple blank lines
Again, not really needed, but doesn't matter much

Applied.

Thanks,

Jonathan

> 
> Signed-off-by: Lucas Oshiro <lucasseikioshiro@...il.com>
> Signed-off-by: Anderson Reis <andersonreisrosa@...il.com>
> ---
>  drivers/iio/potentiostat/lmp91000.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/potentiostat/lmp91000.c b/drivers/iio/potentiostat/lmp91000.c
> index 03d277621861..c45cfb632649 100644
> --- a/drivers/iio/potentiostat/lmp91000.c
> +++ b/drivers/iio/potentiostat/lmp91000.c
> @@ -255,8 +255,8 @@ static int lmp91000_read_config(struct lmp91000_data *data)
>  
>  	regmap_write(data->regmap, LMP91000_REG_LOCK, 0);
>  	regmap_write(data->regmap, LMP91000_REG_TIACN, reg);
> -	regmap_write(data->regmap, LMP91000_REG_REFCN, LMP91000_REG_REFCN_EXT_REF
> -					| LMP91000_REG_REFCN_50_ZERO);
> +	regmap_write(data->regmap, LMP91000_REG_REFCN,
> +		     LMP91000_REG_REFCN_EXT_REF | LMP91000_REG_REFCN_50_ZERO);
>  	regmap_write(data->regmap, LMP91000_REG_LOCK, 1);
>  
>  	return 0;
> @@ -276,7 +276,6 @@ static int lmp91000_buffer_cb(const void *val, void *private)
>  static const struct iio_trigger_ops lmp91000_trigger_ops = {
>  };
>  
> -
>  static int lmp91000_buffer_preenable(struct iio_dev *indio_dev)
>  {
>  	struct lmp91000_data *data = iio_priv(indio_dev);