linux-kernel - Re: [PATCH v2 4/4] iio:potentiostat:lmp91000: change dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190309184946.35c5446d@archlinux>
Date:   Sat, 9 Mar 2019 18:49:46 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Anderson Reis <andersonreisrosa@...il.com>
Cc:     knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
        matt.ranostay@...sulko.com, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-usp@...glegroups.com,
        Anderson Reis <anderson.reis.rosa@....com>,
        Lucas Oshiro <lucasseikioshiro@...il.com>
Subject: Re: [PATCH v2 4/4] iio:potentiostat:lmp91000: change dev_err
 message

On Fri,  8 Mar 2019 16:46:55 -0300
Anderson Reis <andersonreisrosa@...il.com> wrote:

> Change dev_err message on line 215 in order to inform that
> tia-gain-ohm is not defined and an external resistor is not
> specified.
> 
> Signed-off-by: Anderson Reis <andersonreisrosa@...il.com>
> Signed-off-by: Lucas Oshiro <lucasseikioshiro@...il.com>
Applied.

Thanks,

Jonathan

> ---
>  drivers/iio/potentiostat/lmp91000.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/potentiostat/lmp91000.c b/drivers/iio/potentiostat/lmp91000.c
> index 1de17924e154..5ed9752008a5 100644
> --- a/drivers/iio/potentiostat/lmp91000.c
> +++ b/drivers/iio/potentiostat/lmp91000.c
> @@ -212,7 +212,7 @@ static int lmp91000_read_config(struct lmp91000_data *data)
>  	ret = of_property_read_u32(np, "ti,tia-gain-ohm", &val);
>  	if (ret) {
>  		if (!of_property_read_bool(np, "ti,external-tia-resistor"))
> -			dev_err(dev, "no ti,tia-gain-ohm defined");
> +			dev_err(dev, "no ti,tia-gain-ohm defined and external resistor not specified\n");
>  			return ret;
>  		}
>  		val = 0;