linux-kernel - Re: [PATCH 1/5] Staging: rtl8723bs: os_dep: Fix assignment in if condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPTV9hudtZ6_9VL2L=ic-LqMmj5Jb3WR9404isHU0NjxtG5A3A@mail.gmail.com>
Date:   Sat, 9 Mar 2019 16:00:31 -0300
From:   Guilherme T Maeoka <gui.maeoka@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] Staging: rtl8723bs: os_dep: Fix assignment in if condition

Thank you for the review Joe. I'll have that in mind in the next patch.

On 3/9/19, Joe Perches <joe@...ches.com> wrote:
> On Sat, 2019-03-09 at 15:30 -0300, Guilherme Tadashi Maeoka wrote:
>> Fix an assignment in if condition.
>>
>> Signed-off-by: Guilherme Tadashi Maeoka <gui.maeoka@...il.com>
>> ---
>>  drivers/staging/rtl8723bs/os_dep/osdep_service.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c
>> b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
>> index 73b87da15eb2..c7fdcc6bbae3 100644
>> --- a/drivers/staging/rtl8723bs/os_dep/osdep_service.c
>> +++ b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
>> @@ -162,7 +162,9 @@ static int retriveFromFile(char *path, u8 *buf, u32
>> sz)
>>  	struct file *fp;
>>
>>  	if (path && buf) {
>> -		if (0 == (ret =openFile(&fp, path, O_RDONLY, 0))) {
>> +		ret = openFile(&fp, path, O_RDONLY, 0);
>> +
>> +		if (ret == 0) {
>>  			DBG_871X("%s openFile path:%s fp =%p\n", __func__, path , fp);
>>
>>  			oldfs = get_fs(); set_fs(KERNEL_DS);
>
> More common kernel style would be to rewrite the function
> (and to fix the typo of retrieve) to something like:
>
> static int retrieveFromFile(char *path, u8 *buf, u32 sz)
> {
> 	int ret;
> 	mm_segment_t oldfs;
> 	struct file *fp;
>
> 	if (!path || !buf) {
> 		DBG_871X("%s NULL pointer\n", __func__);
> 		return -EINVAL;
> 	}
>
> 	ret = openFile(&fp, path, O_RDONLY, 0);
> 	if (ret) {
> 		DBG_871X("%s openFile path:%s Fail, ret:%d\n",
> 			 __func__, path, ret);
> 		return ret;
> 	}
>
> 	DBG_871X("%s openFile path:%s fp =%p\n", __func__, path , fp);
>
> 	oldfs = get_fs();
> 	set_fs(KERNEL_DS);
> 	ret = readFile(fp, buf, sz);
> 	set_fs(oldfs);
> 	closeFile(fp);
>
> 	DBG_871X("%s readFile, ret:%d\n", __func__, ret);
>
> 	return ret;
> }
>
>
>