linux-kernel - Re: [PATCH net] rxrpc: Fix client call queueing, waiting for channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190308.182536.2245581706498467239.davem@davemloft.net>
Date:   Fri, 08 Mar 2019 18:25:36 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     dhowells@...hat.com
Cc:     netdev@...r.kernel.org, marc.dionne@...istor.com,
        linux-afs@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] rxrpc: Fix client call queueing, waiting for
 channel

From: David Howells <dhowells@...hat.com>
Date: Sat, 09 Mar 2019 00:29:58 +0000

> rxrpc_get_client_conn() adds a new call to the front of the waiting_calls
> queue if the connection it's going to use already exists.  This is bad as
> it allows calls to get starved out.
> 
> Fix this by adding to the tail instead.
> 
> Also change the other enqueue point in the same function to put it on the
> front (ie. when we have a new connection).  This makes the point that in
> the case of a new connection the new call goes at the front (though it
> doesn't actually matter since the queue should be unoccupied).
> 
> Fixes: 45025bceef17 ("rxrpc: Improve management and caching of client connection objects")
> Signed-off-by: David Howells <dhowells@...hat.com>
> Reviewed-by: Marc Dionne <marc.dionne@...istor.com>

Applied and queued up for -stable, thanks David.