linux-kernel - Re: [PATCH] arm64: dts: rockchip: Fix vcc_host1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <164d616b-f445-2aa6-e57a-e6db446eb121@katsuster.net>
Date:   Sat, 9 Mar 2019 11:52:09 +0900
From:   Katsuhiro Suzuki <katsuhiro@...suster.net>
To:     Tomohiro Mayama <parly-gh@...s.mystia.org>, heiko@...ech.de
Cc:     linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] arm64: dts: rockchip: Fix vcc_host1_5v GPIO polarity on
 rk3328-rock64

Hello Mayama-san,

On 2019/03/08 1:18, Tomohiro Mayama wrote:
> This patch makes USB ports functioning again.
> 
> Signed-off-by: Tomohiro Mayama <parly-gh@...s.mystia.org>
> ---
>   arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> index 21107d0f4378..7f365e448867 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> @@ -45,8 +45,7 @@
>   
>   	vcc_host1_5v: vcc_otg_5v: vcc-host1-5v-regulator {
>   		compatible = "regulator-fixed";
> -		enable-active-high;
> -		gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_HIGH>;
> +		gpio = <&gpio0 RK_PA2 GPIO_ACTIVE_LOW>;
>   		pinctrl-names = "default";
>   		pinctrl-0 = <&usb20_host_drv>;
>   		regulator-name = "vcc_host1_5v";
> 

After this patch applied, USB and S/PDIF both work well.

Tested-by: Katsuhiro Suzuki <katsuhiro@...suster.net>


$ lsusb
Bus 003 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 001 Device 002: ID 046d:c526 Logitech, Inc. Nano Receiver
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub


Best Regards,
Katsuhiro Suzuki