linux-kernel - Re: [PATCH 3/4] Add header file,Kconfig and Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c23c156e-0493-96e2-f4eb-0171e8c8fc58@infradead.org>
Date:   Fri, 8 Mar 2019 19:15:32 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Morris Ku <saumah@...il.com>, gregkh@...uxfoundation.org
Cc:     morris_ku@...ix.com, linux-kernel@...r.kernel.org, arnd@...db.de
Subject: Re: [PATCH 3/4] Add header file,Kconfig and Makefile

On 3/8/19 4:35 AM, Morris Ku wrote:
> This patch add header file, Kconfig and Makefile. 
> 
> Signed-off-by: Morris Ku <saumah@...il.com>
> ---

> diff --git a/char/snx/Kconfig b/char/snx/Kconfig
> new file mode 100644
> index 00000000..86f38352
> --- /dev/null
> +++ b/char/snx/Kconfig
> @@ -0,0 +1,15 @@
> +# SPDX-License-Identifier: GPL-2.0
> +#
> +# Character device configuration
> +#
> +
> +config SNX
> +	tristate "SUNIX Multi-IO Board Drvier"

	                               Driver

> +	Driver for SUNIX Multi-I/O Board device driver Based on
> +	drivers/char/serial.c, parport_pc.c, ppdev.c and lp.c by Linus
> +	Torvalds, Theodore Ts'o.

kconfig does not like those 3 lines above.  That indicates some lack of
testing.

They could be put under "help", but they really should just be deleted or
moved to some source file if you think that they are needed.

> +	help
> +	   Say Y here if you have a SUNIX Multi-IO card.

Indent with tab + 2 spaces, not 3 spaces.

> +
> +	  To compile this driver as a module, choose M here: the
> +	  module will be called snx.


-- 
~Randy