linux-kernel - Re: [PATCH] xfs: Use kmem_zalloc for bp->b

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190310215355.GC23020@dastard>
Date:   Mon, 11 Mar 2019 08:53:55 +1100
From:   Dave Chinner <david@...morbit.com>
To:     Sean Fu <fxinrong@...il.com>
Cc:     "Darrick J. Wong" <darrick.wong@...cle.com>,
        linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xfs: Use kmem_zalloc for bp->b_pages.

On Sun, Mar 10, 2019 at 01:07:32PM +0800, Sean Fu wrote:
> On Sat, Mar 09, 2019 at 09:32:30AM -0800, Darrick J. Wong wrote:
> > On Sat, Mar 09, 2019 at 11:36:36PM +0800, Sean Fu wrote:
> > > Change the allocation of bp->b_pages to use kmem_zalloc instead of
> > > kmem_alloc.
> > > Remove unnecessary memset for bp->b_pages.
> > >
> > > This reduces text size by 42 bytes.
> > > Before:
> > >    text	   data	    bss	    dec	    hex	filename
> > >   23335	    588	      8	  23931	   5d7b	./fs/xfs/xfs_buf.o
> > > After:
> > >    text	   data	    bss	    dec	    hex	filename
> > >   23293	    588	      8	  23889	   5d51	./fs/xfs/xfs_buf.o
> > >
> > > Signed-off-by: Sean Fu <fxinrong@...il.com>
> > > ---
> > >  fs/xfs/xfs_buf.c | 3 +--
> > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
> > > index 4f5f2ff3f70f..be4f740b97c1 100644
> > > --- a/fs/xfs/xfs_buf.c
> > > +++ b/fs/xfs/xfs_buf.c
> > > @@ -289,12 +289,11 @@ _xfs_buf_get_pages(
> > >  		if (page_count <= XB_PAGES) {
> > >  			bp->b_pages = bp->b_page_array;
> > >  		} else {
> > > -			bp->b_pages = kmem_alloc(sizeof(struct page *) *
> > > +			bp->b_pages = kmem_zalloc(sizeof(struct page *) *
> > >  						 page_count, KM_NOFS);
> > >  			if (bp->b_pages == NULL)
> > >  				return -ENOMEM;
> > >  		}
> > > -		memset(bp->b_pages, 0, sizeof(struct page *) * page_count);
> >
> > Does this leave b_pages uninitialized in the page_count <= XB_PAGES
> > case?
> bp is allocated by kmem_zone_zalloc, But i will take a deep look at xfs_buf_associate_memory.

We can (and do) reuse buffers with different memory buffers via
xfs_buf_associate_memory() (e.g. see the split log buffer code in
xlog_sync()].

I'd prefer that we leave the explicit memset here for this re-use
case - leaving the page pointer array with stale page pointers (even
though beyond b_page_count) means any page array overrun turns into
a memory corruption (via access of a stale page) rather than a NULL
pointer dereference and immediate fail.

IMO, a small decrease in binary size is not worth changing the
failure behaviour from a definite, immediate fail to a random memory
corruption failure some time in the future...

Cheers,

Dave.
-- 
Dave Chinner
david@...morbit.com