linux-kernel - Re: [PATCH net] net: hns3: fix to stop multiple HNS reset due to the AER changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190309.225937.1758549479086621930.davem@davemloft.net>
Date:   Sat, 09 Mar 2019 22:59:37 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     tanhuazhong@...wei.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        salil.mehta@...wei.com, yisen.zhuang@...wei.com,
        linuxarm@...wei.com, shiju.jose@...wei.com
Subject: Re: [PATCH net] net: hns3: fix to stop multiple HNS reset due to
 the AER changes

From: Huazhong Tan <tanhuazhong@...wei.com>
Date: Sun, 10 Mar 2019 14:47:51 +0800

> From: Shiju Jose <shiju.jose@...wei.com>
> 
> The commit bfcb79fca19d
> ("PCI/ERR: Run error recovery callbacks for all affected devices")
> affected the non-fatal error recovery logic for the HNS and RDMA devices.
> This is because each HNS PF under PCIe bus receive callbacks
> from the AER driver when an error is reported for one of the PF.
> This causes unwanted PF resets because
> the HNS decides which PF to reset based on the reset type set.
> The HNS error handling code sets the reset type based on the hw error
> type detected.
> 
> This patch provides fix for the above issue for the recovery of
> the hw errors in the HNS and RDMA devices.
> 
> This patch needs backporting to the kernel v5.0+
> 
> Fixes: 332fbf576579 ("net: hns3: add handling of hw ras errors using new set of commands")
> Reported-by: Xiaofei Tan <tanxiaofei@...wei.com>
> Signed-off-by: Shiju Jose <shiju.jose@...wei.com>
> Signed-off-by: Huazhong Tan <tanhuazhong@...wei.com>

Applied and queued up for -stable, thanks.