linux-kernel - Re: [PATCH v1 06/10] perf, tools, report: Print better message for JITed code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190311205852.GE10690@kernel.org>
Date:   Mon, 11 Mar 2019 17:58:52 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Andi Kleen <ak@...ux.intel.com>
Cc:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>,
        Andi Kleen <andi@...stfloor.org>, jolsa@...nel.org,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 06/10] perf, tools, report: Print better message for
 JITed code

Em Mon, Mar 11, 2019 at 01:48:56PM -0700, Andi Kleen escreveu:
> On Mon, Mar 11, 2019 at 05:33:02PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Mon, Mar 11, 2019 at 01:24:42PM -0700, Andi Kleen escreveu:
> > > +		if (!strncmp(map->dso->name, "/tmp/perf-", 10)) {
> > > +			static bool warned;
> > > +			if (!warned) {
> > > +				pr_err("Cannot find executable, JITed code present? May need agent.\n");
> > > +				warned = true;
> > > +			}
 
> > Please use WARN_ON_ONCE(), we have it in tools/include/asm/bug.h, just
> > like the kernel.

> But that prints "assertation failed". This is not a perf bug, but can happen
> in normal operation.

Sorry, we also have WARN_ONCE() and that one doesn't have any extra
message printed, only what you pass to it, right?

- Arnaldo