linux-kernel - Re: [LKP] [selftests/vm] a05ef00c97: kernel_selftests.vm.vmalloc_stability_smoke

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190311145613.af4e4ed3adf0718a0a7f3b71@linux-foundation.org>
Date:   Mon, 11 Mar 2019 14:56:13 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     kernel test robot <rong.a.chen@...el.com>,
        Uladzislau Rezki <urezki@...il.com>,
        Shuah Khan <shuah@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Matthew Wilcox <willy@...radead.org>,
        Michal Hocko <mhocko@...e.com>,
        Oleksiy Avramchenko <oleksiy.avramchenko@...ymobile.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>, lkp@...org
Subject: Re: [LKP] [selftests/vm] a05ef00c97:
 kernel_selftests.vm.vmalloc_stability_smoke_test.fail

On Mon, 11 Mar 2019 10:20:06 -0700 Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> On Mon, Mar 11, 2019 at 12:43 AM kernel test robot
> <rong.a.chen@...el.com> wrote:
> >
> > ./run_vmtests: line 217: ./test_vmalloc.sh: Permission denied
> 
> I marked that script executable:
> 
>   6bc3fe8e7e17 ("tools: mark 'test_vmalloc.sh' executable")
> 
> although perhaps the better fix would have been to explicitly use the
> shell to start it in the 'run_vmtests' script instead?
> 
> We have a lot of files that aren't marked executable, probably because
> they came in as (or were generated as) non-git patches. Often through
> Andrew's workflow.

Not only that.  patch(1) doesn't set the x bit.  So if someone
downloads and applies patch-5.0-rc1.xz (as we say to do in the
documentation), their kernel won't work correctly.

This happens fairly regularly and the fix is to replace

	test_vmalloc.sh ...

with

	/bin/sh test_vmalloc.sh ...