linux-kernel - Re: [GIT pull] scheduler updates for 5.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Mar 2019 10:09:01 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Linux List Kernel Mailing <linux-kernel@...r.kernel.org>,
        the arch/x86 maintainers <x86@...nel.org>
Subject: Re: [GIT pull] scheduler updates for 5.1


* Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> On Sun, Mar 10, 2019 at 4:33 AM Thomas Gleixner <tglx@...utronix.de> wrote:
> >
> > A small set of fixes for the scheduler:
> 
> What? No.
> 
> This is completely broken, and even warns loudly about it.
> 
>   kernel/sched/cpufreq_schedutil.c: In function ‘sugov_iowait_boost’:
>   ./include/linux/kernel.h:827:29: warning: comparison of distinct
> pointer types lacks a cast
>   kernel/sched/cpufreq_schedutil.c:346:26: note: in expansion of macro ‘min’
>      sg_cpu->iowait_boost = min(sg_cpu->iowait_boost << 1,
> SCHED_CAPACITY_SCALE);
>                             ^~~
> 
> because 'SCHED_CAPACITY_SCALE' is of type 'long' and 'iowait_boost' is
> 'unsigned int'.
> 
> Why are you sending me code that hasn't even been compiled, and call it a "fix"?

Sorry about that - we'll sort this out!

Thanks,

	Ingo