linux-kernel - Re: 5.0-rc1 Open circuit voltage tables -- 3afb50d7125bc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190311102325.GB14118@amd>
Date:   Mon, 11 Mar 2019 11:23:25 +0100
From:   Pavel Machek <pavel@....cz>
To:     kernel list <linux-kernel@...r.kernel.org>, baolin.wang@...aro.org,
        linus.walleij@...aro.org, sebastian.reichel@...labora.com
Cc:     sre@...nel.org
Subject: Re: 5.0-rc1 Open circuit voltage tables -- 3afb50d7125bc

On Mon 2019-01-07 20:05:55, Pavel Machek wrote:
> Hi!
> 
> Can we do something with that code?
> 
> First -- tables should not be necceessary. Formula for li-ion open
> circuit voltage is well-known, and does not really depend on the
> device -- only on the chemistry of battery.
> 
> state of charge = f( voltage, current, internal resistance )
> 
> (And yes, internal resistance depends on temperature and health of the
> battery).
> 
> Second, even if we need tables, why is it doing multiple allocations?
> 
> info->ocv_temp[index]        = -EINVAL;
> 
> That's just wrong. Ocv_temp is temperature in celsius. Temperatures go
> below zero.

Ping? That code is just bad. Does someone care?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)