linux-kernel - Re: [PATCH] gpio: omap: avoid clang warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a1+yitZDApTkkz843NBhi++A54rupi_cBKa59K1XQ6N2Q@mail.gmail.com>
Date:   Mon, 11 Mar 2019 13:09:21 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Bartosz Golaszewski <bgolaszewski@...libre.com>
Cc:     Grygorii Strashko <grygorii.strashko@...com>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Kevin Hilman <khilman@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Tony Lindgren <tony@...mide.com>,
        Janusz Krzysztofik <jmkrzyszt@...il.com>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Linux-OMAP <linux-omap@...r.kernel.org>,
        linux-gpio <linux-gpio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: omap: avoid clang warning

On Mon, Mar 11, 2019 at 10:40 AM Bartosz Golaszewski
<bgolaszewski@...libre.com> wrote:
> czw., 7 mar 2019 o 11:39 Arnd Bergmann <arnd@...db.de> napisał(a):
> > clang warns about a tentative array definition in the gpio-omap driver:
> >
> > drivers/gpio/gpio-omap.c:1282:34: error: tentative array definition assumed to have one element [-Werror]
> > static const struct of_device_id omap_gpio_match[];
> >
> > It's best to just reorder the entire file to avoid forward declarations,
> > which lets us use the regular declaration. To do this, the unnecessary
> > CONFIG_OF check must also be removed.
> >

> > +static const struct dev_pm_ops gpio_pm_ops = {
> > +       SET_RUNTIME_PM_OPS(omap_gpio_runtime_suspend, omap_gpio_runtime_resume,
> > +                                                                       NULL)
> > +};
> > +
> >  static struct platform_driver omap_gpio_driver = {
> >         .probe          = omap_gpio_probe,
> >         .remove         = omap_gpio_remove,
> >         .driver         = {
> >                 .name   = "omap_gpio",
> >                 .pm     = &gpio_pm_ops,
> > -               .of_match_table = of_match_ptr(omap_gpio_match),
> > +               .of_match_table = omap_gpio_match,
>
> This doesn't seem like a logical part of this commit. Can you send a
> separate patch?
>
> Other than that, looks good to me.

This change has to be kept together the with removal of the #ifdef,
otherwise I'd introduce a new warning about an unused variable.

I could try to split out the reordering of the file though.

      Arnd