linux-kernel - Re: [PATCH] drm/bochs: Fix NULL dereference on atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190311130716.6hjqci43clic5lxx@sirius.home.kraxel.org>
Date:   Mon, 11 Mar 2019 14:07:16 +0100
From:   Gerd Hoffmann <kraxel@...hat.com>
To:     Rodrigo Siqueira <rodrigosiqueiramelo@...il.com>
Cc:     David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>,
        virtualization@...ts.linux-foundation.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bochs: Fix NULL dereference on atomic_disable helper

  Hi,

> > >  static void bochs_crtc_atomic_flush(struct drm_crtc *crtc,
> > >  				    struct drm_crtc_state *old_crtc_state)
> > >  {
> > > @@ -66,6 +71,7 @@ static const struct drm_crtc_funcs bochs_crtc_funcs = {
> > >  static const struct drm_crtc_helper_funcs bochs_helper_funcs = {
> > >  	.mode_set_nofb = bochs_crtc_mode_set_nofb,
> > >  	.atomic_enable = bochs_crtc_atomic_enable,
> > > +	.atomic_disable = bochs_crtc_atomic_disable,
> > 
> > Shouldn't we make the callback optional instead of adding empty dummy
> > functions to drivers?
> 
> Hi Gerd,
> 
> I agree, and I can work in this issue.
> Just one question, should we make atomic_enable optional as well?

IIRC the drm code checks for the atomic_enable callback presence to
figure whenever it should take the atomic or legacy code paths.

So, I think that will not work.

cheers,
  Gerd