linux-kernel - Re: [PATCH v3] scsi: smartpqi_init: Reporting 'logical unit failure'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <21c537b9-5d45-d170-cfdb-d49a3e36b924@criteo.com>
Date:   Mon, 11 Mar 2019 16:43:25 +0000
From:   Erwan Velu <e.velu@...teo.com>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>,
        Erwan Velu <erwanaliasr1@...il.com>
CC:     Don Brace <don.brace@...rosemi.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "esc.storagedev@...rosemi.com" <esc.storagedev@...rosemi.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] scsi: smartpqi_init: Reporting 'logical unit failure'

Le 06/03/2019 à 18:34, Martin K. Petersen a écrit :
> Erwan,
>
>> When the HARDWARE_ERROR/0x3e/0x1 case is triggered, the logical volume
>> is offlined.  When reading the kernel log, the reason why the device
>> got offlined isn't reported to the user.  This situation makes
>> difficult for admins to estimate the root cause of the issue they
>> analize.

While I was debugging this scenario, I was wondering if some other cases 
were possible.

The current code is considering  (sshdr.asc == 0x3e && sshdr.ascq == 
0x1), but what if ascq have a different value here ?

The specification (http://www.t10.org/lists/asc-num.htm#ASC_3E) reports 
other sub-values like ASCQ==02 which means a timeout on the lun.

So, does the raid controllers supported by smartpqi can generates these 
other values ? If so, how/where are they handled ?

I was considering at least, to a switch statement on sshdr.ascq with a 
0x1 case on the current code and a a default one that prints at least a 
message saying that a message got received but not handled.

Thanks !

Erwan,