[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ee13f836-bd77-22b0-e230-2fc9050afe88@ti.com>
Date: Mon, 11 Mar 2019 12:24:09 -0500
From: Dan Murphy <dmurphy@...com>
To: Jacek Anaszewski <jacek.anaszewski@...il.com>,
<robh+dt@...nel.org>, <pavel@....cz>, <tony@...mide.com>,
<lee.jones@...aro.org>
CC: <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-leds@...r.kernel.org>
Subject: Re: [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver
Jacek
On 3/11/19 12:22 PM, Jacek Anaszewski wrote:
> Dan,
>
> One more thing I forgot to mention before.
>
> On 3/11/19 12:36 PM, Dan Murphy wrote:
>> Jacek
> [...]
>>
>>>> @@ -0,0 +1,72 @@
>>>> +/* SPDX-License-Identifier: GPL-2.0 */
>>>> +/* TI LM3532 LED driver
>>>> + * Copyright (C) 2019 Texas Instruments Incorporated - http://www.ti.com/
>>>> + */
>
> Let's have "//" comments here.
>
Like I said earlier in v2 this header went away.
And checkpatch takes issue with // in headers.
Unless they have removed that requirement.
Dan
>>>> +#ifndef __DT_BINDINGS_LEDS_LM3532_H
>>>> +#define __DT_BINDINGS_LEDS_LM3532_H
>>>> +
>>>> +#define LM3532_BL_MODE_MANUAL 0x00 /* "man" */
>>>> +#define LM3532_BL_MODE_ALS 0x01 /* "als" */
>>>> +
>>>> +/* ALS Resistor Select */
>>>> +#define LM3532_IMP_HIGH 0x00
>>>> +#define LM3532_IMP_37K 0x01
>>>> +#define LM3532_IMP_18_5K 0x02
>>>> +#define LM3532_IMP_12_33K 0x03
>>>> +#define LM3532_IMP_9_25K 0x04
>>>> +#define LM3532_IMP_7_4K 0x05
>>>> +#define LM3532_IMP_6_17K 0x06
>>>> +#define LM3532_IMP_5_29K 0x07
>>>> +#define LM3532_IMP_4_63K 0x08
>>>> +#define LM3532_IMP_4_11K 0x09
>>>> +#define LM3532_IMP_3_7K 0x0a
>>>> +#define LM3532_IMP_3_36K 0x0b
>>>> +#define LM3532_IMP_3_08K 0x0c
>>>> +#define LM3532_IMP_2_85K 0x0d
>>>> +#define LM3532_IMP_2_64K 0x0e
>>>> +#define LM3532_IMP_2_44K 0x0f
>>>> +#define LM3532_IMP_2_31K 0x10
>>>> +#define LM3532_IMP_2_18K 0x11
>>>> +#define LM3532_IMP_2_06K 0x12
>>>> +#define LM3532_IMP_1_95K 0x13
>>>> +#define LM3532_IMP_1_85K 0x14
>>>> +#define LM3532_IMP_1_76K 0x15
>>>> +#define LM3532_IMP_1_68K 0x16
>>>> +#define LM3532_IMP_1_61K 0x17
>>>> +#define LM3532_IMP_1_54K 0x18
>>>> +#define LM3532_IMP_1_48K 0x19
>>>> +#define LM3532_IMP_1_42K 0x1a
>>>> +#define LM3532_IMP_1_37K 0x1b
>>>> +#define LM3532_IMP_1_32K 0x1c
>>>> +#define LM3532_IMP_1_28K 0x1d
>>>> +#define LM3532_IMP_1_23K 0x1e
>>>> +#define LM3532_IMP_1_19K 0x1f
>>>> +
>>>> +/* ALS Averaging Time */
>>>> +#define LM3532_ALS_AVRG_TIME_17_92ms 0x00
>>>> +#define LM3532_ALS_AVRG_TIME_35_84ms 0x01
>>>> +#define LM3532_ALS_AVRG_TIME_71_68ms 0x02
>>>> +#define LM3532_ALS_AVRG_TIME_143_36ms 0x03
>>>> +#define LM3532_ALS_AVRG_TIME_286_72ms 0x04
>>>> +#define LM3532_ALS_AVRG_TIME_573_44ms 0x05
>>>> +#define LM3532_ALS_AVRG_TIME_1146_88ms 0x06
>>>> +#define LM3532_ALS_AVRG_TIME_2293_76ms 0x07
>>>> +
>>>> +/* ALS input select */
>>>> +#define LM3532_ALS_INPUT_AVRG 0x00 /* ALS1 and ALS2 input average */
>>>> +#define LM3532_ALS_INPUT_ALS1 0x01 /* ALS1 Input */
>>>> +#define LM3532_ALS_INPUT_ALS2 0x02 /* ALS2 Input */
>>>> +#define LM3532_ALS_INPUT_CEIL 0x03 /* Max of ALS1 and ALS2 */
>>>> +
>>>> +/* Ramp Times */
>>>> +#define LM3532_RAMP_8us 0x00
>>>> +#define LM3532_RAMP_1024us 0x01
>>>> +#define LM3532_RAMP_2048us 0x02
>>>> +#define LM3532_RAMP_4096us 0x03
>>>> +#define LM3532_RAMP_8192us 0x04
>>>> +#define LM3532_RAMP_16384us 0x05
>>>> +#define LM3532_RAMP_32768us 0x06
>>>> +#define LM3532_RAMP_65536us 0x07
>>>> +
>>>> +#endif /* __DT_BINDINGS_LEDS_LM3532_H */
>>>>
>>>
>>
>>
>
--
------------------
Dan Murphy
Powered by blists - more mailing lists