linux-kernel - Re: [PATCH] mips: loongson64: lemote-2f: Add IRQF_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 11 Mar 2019 18:14:01 +0000
From:   Paul Burton <paul.burton@...s.com>
To:     Yifeng Li <tomli@...li.me>
CC:     "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Huacai Chen <chenhc@...ote.com>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Paul Burton <pburton@...ecomp.com>,
        James Hogan <jhogan@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Yifeng Li <tomli@...li.me>,
        "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>
Subject: Re: [PATCH] mips: loongson64: lemote-2f: Add IRQF_NO_SUSPEND to
 "cascade"  irqaction.

Hello,

Yifeng Li wrote:
> Timekeeping IRQs from CS5536 MFGPT are routed to i8259, which then
> triggers the "cascade" IRQ on MIPS CPU. Without IRQF_NO_SUSPEND in
> cascade_irqaction, MFGPT interrupts will be masked in suspend mode,
> and the machine would be unable to resume once suspended.
> 
> Previously, MIPS IRQs were not disabled properly, so the original
> code appeared to work. Commit a3e6c1eff5 (MIPS: IRQ: Fix disable_irq
> on CPU IRQs) uncovers the bug. To fix it, add IRQF_NO_SUSPEND to
> cascade_irqaction.
> 
> This commit is functionally identical to 0add9c2f1cff ("MIPS:
> Loongson-3: Add IRQF_NO_SUSPEND to Cascade irqaction"), but it forgot
> to apply the same fix to Loongson2.
> 
> Signed-off-by: Yifeng Li <tomli@...li.me>

Applied to mips-fixes.

Thanks,
    Paul

[ This message was auto-generated; if you believe anything is incorrect
  then please email paul.burton@...s.com to report it. ]