linux-kernel - Re: [PATCH v6 09/11] perf tools report: Add custom scripts to script menu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190311183455.GB29294@tassilo.jf.intel.com>
Date:   Mon, 11 Mar 2019 11:34:55 -0700
From:   Andi Kleen <ak@...ux.intel.com>
To:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
Cc:     Andi Kleen <andi@...stfloor.org>, jolsa@...nel.org,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 09/11] perf tools report: Add custom scripts to script
 menu

> Isn't it better to use 'scripts' for those scripts and leave 'script'
> for configuring the 'perf script' command like we have options for
> annotate, etc?

Yes that's fine.

That's just two character updates in the doc and in the strstarts below. 
If there's nothing else can you please just do these changes when you apply?

Thanks.

> > +static int scripts_config(const char *var, const char *value, void *data)
> > +{
> > +	struct script_config *c = data;
> > +
> > +	if (!strstarts(var, "script."))
> > +		return -1;