linux-kernel - Re: [PATCH v6 09/11] perf tools report: Add custom scripts to script menu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190311184534.GZ10690@kernel.org>
Date:   Mon, 11 Mar 2019 15:45:34 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Andi Kleen <ak@...ux.intel.com>
Cc:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>,
        Andi Kleen <andi@...stfloor.org>, jolsa@...nel.org,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 09/11] perf tools report: Add custom scripts to script
 menu

Em Mon, Mar 11, 2019 at 11:34:55AM -0700, Andi Kleen escreveu:
> > Isn't it better to use 'scripts' for those scripts and leave 'script'
> > for configuring the 'perf script' command like we have options for
> > annotate, etc?
> 
> Yes that's fine.
> 
> That's just two character updates in the doc and in the strstarts below. 
> If there's nothing else can you please just do these changes when you apply?

Sure, doing that now.
 
> Thanks.
> 
> > > +static int scripts_config(const char *var, const char *value, void *data)
> > > +{
> > > +	struct script_config *c = data;
> > > +
> > > +	if (!strstarts(var, "script."))
> > > +		return -1;

-- 

- Arnaldo