linux-kernel - Re: [PATCH 05/42] drivers: gpio: bcm-kona: use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04b068f6-8045-98fc-de8d-f9b5e2d7acde@gmail.com>
Date:   Mon, 11 Mar 2019 11:59:57 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     "Enrico Weigelt, metux IT consult" <info@...ux.net>,
        linux-kernel@...r.kernel.org
Cc:     linus.walleij@...aro.org, bgolaszewski@...libre.com,
        andrew@...id.au, f.fainelli@...il.com, sbranden@...adcom.com,
        bcm-kernel-feedback-list@...adcom.com, hoan@...amperecomputing.com,
        orsonzhai@...il.com, baolin.wang@...aro.org, zhang.lyra@...il.com,
        keguang.zhang@...il.com, vz@...ia.com, matthias.bgg@...il.com,
        thierry.reding@...il.com, grygorii.strashko@...com,
        ssantosh@...nel.org, khilman@...nel.org, robert.jarzmik@...e.fr,
        yamada.masahiro@...ionext.com, jun.nie@...aro.org,
        shawnguo@...nel.org, linux-gpio@...r.kernel.org,
        linux-mips@...r.kernel.org, linux-pwm@...r.kernel.org,
        linux-omap@...r.kernel.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH 05/42] drivers: gpio: bcm-kona: use
 devm_platform_ioremap_resource()

On 3/11/19 11:54 AM, Enrico Weigelt, metux IT consult wrote:
> Use the new helper that wraps the calls to platform_get_resource()
> and devm_ioremap_resource() together.
> 
> Signed-off-by: Enrico Weigelt, metux IT consult <info@...ux.net>
> ---
>  drivers/gpio/gpio-bcm-kona.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c
> index c5536a5..9fa6d3a 100644
> --- a/drivers/gpio/gpio-bcm-kona.c
> +++ b/drivers/gpio/gpio-bcm-kona.c
> @@ -568,7 +568,6 @@ static int bcm_kona_gpio_probe(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
>  	const struct of_device_id *match;
> -	struct resource *res;
>  	struct bcm_kona_gpio_bank *bank;
>  	struct bcm_kona_gpio *kona_gpio;
>  	struct gpio_chip *chip;
> @@ -618,8 +617,7 @@ static int bcm_kona_gpio_probe(struct platform_device *pdev)
>  		return -ENXIO;
>  	}
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	kona_gpio->reg_base = devm_ioremap_resource(dev, res);
> +	kona_gpio->reg_base = devm_platform_ioremap_resource(pdev, 0);

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian