linux-kernel - Re: [PATCHv7 07/10] acpi/hmat: Register processor domain to its memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Mar 2019 13:52:44 -0600
From:   Keith Busch <kbusch@...nel.org>
To:     Jonathan Cameron <jonathan.cameron@...wei.com>
Cc:     Keith Busch <keith.busch@...el.com>, linux-kernel@...r.kernel.org,
        linux-acpi@...r.kernel.org, linux-mm@...ck.org,
        linux-api@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rafael Wysocki <rafael@...nel.org>,
        Dave Hansen <dave.hansen@...el.com>,
        Dan Williams <dan.j.williams@...el.com>
Subject: Re: [PATCHv7 07/10] acpi/hmat: Register processor domain to its
 memory

On Mon, Mar 11, 2019 at 11:20:41AM +0000, Jonathan Cameron wrote:
> On Wed, 27 Feb 2019 15:50:35 -0700
> Keith Busch <keith.busch@...el.com> wrote:
> > +static __init void hmat_register_target_initiators(struct memory_target *target)
> > +{
> > +	static DECLARE_BITMAP(p_nodes, MAX_NUMNODES);
> > +	struct memory_initiator *initiator;
> > +	unsigned int mem_nid, cpu_nid;
> > +	struct memory_locality *loc = NULL;
> > +	u32 best = 0;
> > +	int i;
> > +
> (upshot of the below is I removed this test :)
> > +	if (target->processor_pxm == PXM_INVAL)
> > +		return;
> 
> This doesn't look right.  We check first if it is invalid  and return....

Yeah, Brice mentioned the same bug. I must have been mistakenly
reintroduced that when I rebased to linux-next. I also have a test case
for this and recall it was working at one point. I've got it fixed up
now for the next revision.