linux-kernel - [PATCH 4.14 007/135] staging: android: ion: fix sys heap pools gfp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Mar 2019 10:07:34 -0700
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     linux-kernel@...r.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        stable@...r.kernel.org, Qing Xia <saberlily.xia@...ilicon.com>,
        Jing Xia <jing.xia@...soc.com>,
        Yuming Han <yuming.han@...soc.com>,
        Zhaoyang Huang <zhaoyang.huang@...soc.com>,
        Orson Zhai <orson.zhai@...soc.com>
Subject: [PATCH 4.14 007/135] staging: android: ion: fix sys heap pools gfp_flags

4.14-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Qing Xia <saberlily.xia@...ilicon.com>

commit 9bcf065e28122588a6cbee08cf847826dacbb438 upstream.

In the first loop, gfp_flags will be modified to high_order_gfp_flags,
and there will be no chance to change back to low_order_gfp_flags.

Fixes: e7f63771b60e ("ION: Sys_heap: Add cached pool to spead up cached buffer alloc")
Signed-off-by: Qing Xia <saberlily.xia@...ilicon.com>
Cc: stable <stable@...r.kernel.org>
Signed-off-by: Jing Xia <jing.xia@...soc.com>
Reviewed-by: Yuming Han <yuming.han@...soc.com>
Reviewed-by: Zhaoyang Huang <zhaoyang.huang@...soc.com>
Reviewed-by: Orson Zhai <orson.zhai@...soc.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

---
 drivers/staging/android/ion/ion_system_heap.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/staging/android/ion/ion_system_heap.c
+++ b/drivers/staging/android/ion/ion_system_heap.c
@@ -298,10 +298,10 @@ static int ion_system_heap_create_pools(
 					bool cached)
 {
 	int i;
-	gfp_t gfp_flags = low_order_gfp_flags;
 
 	for (i = 0; i < NUM_ORDERS; i++) {
 		struct ion_page_pool *pool;
+		gfp_t gfp_flags = low_order_gfp_flags;
 
 		if (orders[i] > 4)
 			gfp_flags = high_order_gfp_flags;