linux-kernel - [PATCH] virtio_ring: Fix potential mem leak in virtqueue_add_indirect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190312070653.16392-1-yuehaibing@huawei.com>
Date:   Tue, 12 Mar 2019 15:06:53 +0800
From:   Yue Haibing <yuehaibing@...wei.com>
To:     <mst@...hat.com>, <jasowang@...hat.com>
CC:     <linux-kernel@...r.kernel.org>,
        <virtualization@...ts.linux-foundation.org>,
        YueHaibing <yuehaibing@...wei.com>
Subject: [PATCH] virtio_ring: Fix potential mem leak in virtqueue_add_indirect_packed

From: YueHaibing <yuehaibing@...wei.com>

'desc' should be freed before leaving from err handing path.

Fixes: 1ce9e6055fa0 ("virtio_ring: introduce packed ring support")
Signed-off-by: YueHaibing <yuehaibing@...wei.com>
---
 drivers/virtio/virtio_ring.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
index a0b07c3..9d95d9c 100644
--- a/drivers/virtio/virtio_ring.c
+++ b/drivers/virtio/virtio_ring.c
@@ -991,6 +991,7 @@ static int virtqueue_add_indirect_packed(struct vring_virtqueue *vq,
 
 	if (unlikely(vq->vq.num_free < 1)) {
 		pr_debug("Can't add buf len 1 - avail = 0\n");
+		kfree(desc);
 		END_USE(vq);
 		return -ENOSPC;
 	}
-- 
2.7.0