linux-kernel - Re: [PATCH] net: ravb_main: fix a missing check of of_get_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 12 Mar 2019 10:42:10 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Kangjie Lu <kjlu@....edu>
Cc:     pakki001@....edu, "David S. Miller" <davem@...emloft.net>,
        Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>,
        Simon Horman <horms+renesas@...ge.net.au>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Niklas Söderlund 
        <niklas.soderlund+renesas@...natech.se>,
        Andrew Lunn <andrew@...n.ch>,
        Magnus Damm <damm+renesas@...nsource.se>,
        Kazuya Mizuguchi <kazuya.mizuguchi.ks@...esas.com>,
        netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ravb_main: fix a missing check of of_get_phy_mode

On 12.03.2019 10:38, Sergei Shtylyov wrote:

>> of_get_phy_mode may fail and return a negative error code;
>> the fix checks the return value of of_get_phy_mode and
>> goes to out_release if it fails.
>>
>> Signed-off-by: Kangjie Lu <kjlu@....edu>
>> ---
>>   drivers/net/ethernet/renesas/ravb_main.c | 8 +++++++-
>>   1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/renesas/ravb_main.c 
>> b/drivers/net/ethernet/renesas/ravb_main.c
>> index d28c8f9ca55b..791b6842eb12 100644
>> --- a/drivers/net/ethernet/renesas/ravb_main.c
>> +++ b/drivers/net/ethernet/renesas/ravb_main.c
>> @@ -1996,6 +1996,7 @@ static int ravb_probe(struct platform_device *pdev)
>>       int error, irq, q;
>>       struct resource *res;
>>       int i;
>> +    int ret;
> 
>     There's the 'error' variable already for such things, use it.

    Please ignore that. But the variable could be named 'interface' or 
somesuch. :-)

[...]

MBR, Sergei