linux-kernel - Re: [PATCH] spi: spi-fsl-qspi: call spi_unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190312094348.177c5dd2@ares.tec.linutronix.de>
Date:   Tue, 12 Mar 2019 09:43:48 +0100
From:   Volker Haspel <volker.haspel@...utronix.de>
To:     Mark Brown <broonie@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org,
        Han Xu <han.xu@....com>, john.ogness@...utronix.de
Subject: Re: [PATCH] spi: spi-fsl-qspi: call spi_unregister_controller

On Mon, 11 Mar 2019 17:03:34 +0000
Mark Brown <broonie@...nel.org> wrote:

> On Thu, Mar 07, 2019 at 11:30:08AM +0100, Volker Haspel wrote:
> > The driver does not clearly unregister the spi controller.
> > Therefore calling an unbind and bind again will end up in a
> > Kernel crash.
> > Each driver who calls spi_register_controller() in the probe function
> > has to call spi_unregister_controller() too.  
> 
> Why not change it to use devm?

Hi Mark,

I agree, this is a much nicer solution! I will test it and send a v2.

Thanks

Content of type "application/pgp-signature" skipped