linux-kernel - Re: [PATCH] arm64: dts: meson-gxl-s905d-phicomm-n1: add status LED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Mar 2019 09:59:20 +0100
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Chuanhong Guo <gch981213@...il.com>, devicetree@...r.kernel.org
Cc:     Mark Rutland <mark.rutland@....com>,
        Kevin Hilman <khilman@...libre.com>,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        linux-amlogic@...ts.infradead.org
Subject: Re: [PATCH] arm64: dts: meson-gxl-s905d-phicomm-n1: add status LED

Hi Chuanhong,

On 12/03/2019 09:33, Chuanhong Guo wrote:
> There is a white LED on the front panel behind the logo and the
> manufacturer uses that LED to indicate network and USB drive status.
> 
> Signed-off-by: Chuanhong Guo <gch981213@...il.com>
> ---
>  .../boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts    | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
> index 9a8a8a7e4b53..b5667f1fb2c8 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
> @@ -14,6 +14,16 @@
>  	cvbs-connector {
>  		status = "disabled";
>  	};
> +
> +	leds {
> +		compatible = "gpio-leds";
> +
> +		status {
> +			label = "n1:white:status";
> +			gpios = <&gpio_ao GPIOAO_9 GPIO_ACTIVE_HIGH>;
> +			default-state = "on";
> +		};
> +	};
>  };
>  
>  &cvbs_vdac_port {
> 

Reviewed-by: Neil Armstrong <narmstrong@...libre.com>

BTW, do you know if it's possible to have a sample of the Phicomm N1
in order to be added in kernelci ?

Neil