linux-kernel - Re: [PATCH 16/42] drivers: gpio: janz-ttl: drop unneccessary temp variable dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Mar 2019 10:33:44 +0100
From:   "Enrico Weigelt, metux IT consult" <lkml@...ux.net>
To:     Ben Dooks <ben.dooks@...ethink.co.uk>,
        "Enrico Weigelt, metux IT consult" <info@...ux.net>,
        linux-kernel@...r.kernel.org
Cc:     linus.walleij@...aro.org, bgolaszewski@...libre.com,
        andrew@...id.au, f.fainelli@...il.com, sbranden@...adcom.com,
        bcm-kernel-feedback-list@...adcom.com, hoan@...amperecomputing.com,
        orsonzhai@...il.com, baolin.wang@...aro.org, zhang.lyra@...il.com,
        keguang.zhang@...il.com, vz@...ia.com, matthias.bgg@...il.com,
        thierry.reding@...il.com, grygorii.strashko@...com,
        ssantosh@...nel.org, khilman@...nel.org, robert.jarzmik@...e.fr,
        yamada.masahiro@...ionext.com, jun.nie@...aro.org,
        shawnguo@...nel.org, linux-gpio@...r.kernel.org,
        linux-mips@...r.kernel.org, linux-pwm@...r.kernel.org,
        linux-omap@...r.kernel.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH 16/42] drivers: gpio: janz-ttl: drop unneccessary temp
 variable dev

On 12.03.19 10:17, Ben Dooks wrote:
> On 11/03/2019 18:54, Enrico Weigelt, metux IT consult wrote:
>> don't need the temporary variable "dev", directly use &pdev->dev
>>
>> Signed-off-by: Enrico Weigelt, metux IT consult <info@...ux.net>
> 
> This is quite usual to do, and I like it as it saves typing.
> Personally I would say don't bother with this change.

hmm, both approaches have their valid arguments.

I'm not particularily biased to one or another ay, but I'd prefer
having it consistent  everywhere.


--mtx

-- 
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@...ux.net -- +49-151-27565287