linux-kernel - Re: [PATCH v2 3/3] x86/kdump/64: Change the upper limit of crashkernel reservation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 12 Mar 2019 18:12:48 +0800
From:   Baoquan He <bhe@...hat.com>
To:     "Kirill A. Shutemov" <kirill@...temov.name>
Cc:     linux-kernel@...r.kernel.org, tglx@...utronix.de,
        kirill.shutemov@...ux.intel.com, mingo@...nel.org, bp@...en8.de,
        hpa@...or.com, dyoung@...hat.com, x86@...nel.org
Subject: Re: [PATCH v2 3/3] x86/kdump/64: Change the upper limit of
 crashkernel reservation

On 03/12/19 at 12:48pm, Kirill A. Shutemov wrote:
> >  #ifdef CONFIG_X86_32
> >  # define CRASH_ADDR_LOW_MAX	(512 << 20)
> >  # define CRASH_ADDR_HIGH_MAX	(512 << 20)
> >  #else
> >  # define CRASH_ADDR_LOW_MAX	(896UL << 20)
> > -# define CRASH_ADDR_HIGH_MAX	MAXMEM
> > +# define CRASH_ADDR_HIGH_MAX	(1ULL < 46)
> 
> Maybe
> 
> # define CRASH_ADDR_HIGH_MAX (64UL << 40)
> 
> to match the notation for the rest of defines?
> 
Sure, I will replace it, and repost a whole patchset with your ack added
on each patch. Thanks for your careful reviewing and great suggestions.

> 
> Otherwise the patchset look good to me. You can use my ack for all of
> them:
> 
> Acked-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
> 
> >  #endif
> >  
> >  static int __init reserve_crashkernel_low(void)
> > -- 
> > 2.17.2
> > 
> 
> -- 
>  Kirill A. Shutemov