linux-kernel - Re: [PATCH 10/42] drivers: gpio: ep93xx: devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Mar 2019 12:23:24 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     "Enrico Weigelt, metux IT consult" <info@...ux.net>
Cc:     linux-kernel@...r.kernel.org, linus.walleij@...aro.org,
        bgolaszewski@...libre.com, andrew@...id.au, f.fainelli@...il.com,
        sbranden@...adcom.com, bcm-kernel-feedback-list@...adcom.com,
        hoan@...amperecomputing.com, orsonzhai@...il.com,
        baolin.wang@...aro.org, zhang.lyra@...il.com,
        keguang.zhang@...il.com, vz@...ia.com, matthias.bgg@...il.com,
        grygorii.strashko@...com, ssantosh@...nel.org, khilman@...nel.org,
        robert.jarzmik@...e.fr, yamada.masahiro@...ionext.com,
        jun.nie@...aro.org, shawnguo@...nel.org,
        linux-gpio@...r.kernel.org, linux-mips@...r.kernel.org,
        linux-pwm@...r.kernel.org, linux-omap@...r.kernel.org,
        linux-tegra@...r.kernel.org
Subject: Re: [PATCH 10/42] drivers: gpio: ep93xx:
 devm_platform_ioremap_resource()

On Mon, Mar 11, 2019 at 07:54:49PM +0100, Enrico Weigelt, metux IT consult wrote:
> Use the new helper that wraps the calls to platform_get_resource()
> and devm_ioremap_resource() together.
> 
> Signed-off-by: Enrico Weigelt, metux IT consult <info@...ux.net>
> ---
>  drivers/gpio/gpio-ep93xx.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c
> index 71728d6..52e9a7b2 100644
> --- a/drivers/gpio/gpio-ep93xx.c
> +++ b/drivers/gpio/gpio-ep93xx.c
> @@ -393,16 +393,13 @@ static int ep93xx_gpio_add_bank(struct gpio_chip *gc, struct device *dev,
>  static int ep93xx_gpio_probe(struct platform_device *pdev)
>  {
>  	struct ep93xx_gpio *epg;
> -	struct resource *res;
>  	int i;
> -	struct device *dev = &pdev->dev;
>  
> -	epg = devm_kzalloc(dev, sizeof(*epg), GFP_KERNEL);
> +	epg = devm_kzalloc(&odev->dev, sizeof(*epg), GFP_KERNEL);

odev -> pdev

You should write some scripts to compile-test these changes. Compilers
are good at catching these silly typos. Humans not so much.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)