linux-kernel - Re: [PATCH] scsi: qla2xxx: Fix a small typo in qla

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 12 Mar 2019 13:06:09 +0100 (CET)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     "Milan P. Gandhi" <mgandhi@...hat.com>
cc:     kernel-janitors@...r.kernel.org, qla2xxx-upstream@...gic.com,
        jejb@...ux.ibm.com, martin.petersen@...cle.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: qla2xxx: Fix a small typo in qla_bsg.c



On Tue, 12 Mar 2019, Milan P. Gandhi wrote:

> This patch fixes a minor formatting issue with comment section and a
> typo for 'iiDMA' cmd in drivers/scsi/qla2xxx/qla_bsg.c

This seems to be two completely unrelated changes.  The subject line
promises only one change, and indeed only one change per patch would have
been better.  You should make a series.

julia

>
> Signed-off-by: Milan P. Gandhi <mgandhi@...hat.com>
> ---
> diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c
> index 17d42658ad9a..2353be988907 100644
> --- a/drivers/scsi/qla2xxx/qla_bsg.c
> +++ b/drivers/scsi/qla2xxx/qla_bsg.c
> @@ -1,4 +1,4 @@
> -	/*
> +/*
>   * QLogic Fibre Channel HBA Driver
>   * Copyright (c)  2003-2014 QLogic Corporation
>   *
> @@ -1354,7 +1354,7 @@ qla24xx_iidma(struct bsg_job *bsg_job)
>
>  	if (rval) {
>  		ql_log(ql_log_warn, vha, 0x704c,
> -		    "iIDMA cmd failed for %8phN -- "
> +		    "iiDMA cmd failed for %8phN -- "
>  		    "%04x %x %04x %04x.\n", fcport->port_name,
>  		    rval, fcport->fp_speed, mb[0], mb[1]);
>  		rval = (DID_ERROR << 16);
>