linux-kernel - Re: [PATCH] ata: pata_oldpiix: Add missing device ID for INTEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190312133808.GA9336@Red>
Date:   Tue, 12 Mar 2019 14:38:08 +0100
From:   LABBE Corentin <clabbe@...libre.com>
To:     Alan Cox <gnomes@...rguk.ukuu.org.uk>
Cc:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        axboe@...nel.dk, b.zolnierkie@...sung.com,
        linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ata: pata_oldpiix: Add missing device ID for
 INTEL_82371AB

On Tue, Mar 12, 2019 at 12:06:23PM +0000, Alan Cox wrote:
> On Tue, 12 Mar 2019 11:41:02 +0100
> LABBE Corentin <clabbe@...libre.com> wrote:
> 
> > On Mon, Dec 10, 2018 at 05:52:35PM +0300, Sergei Shtylyov wrote:
> > > Hello!
> > > 
> > > On 12/10/2018 04:46 PM, Corentin Labbe wrote:
> > >   
> > > > When playing with a virtual SPARC machine with qemu, I found that the
> > > > IDE emulated device was not probing with the ata/pata_oldpiix driver.  
> > > 
> > >    Correctly, it should probe with ata_piix,
> > >   
> > > > But with the old ide/piix, it was probed.> 
> > > > This is due to this PCI devid was not migrated from the old ide/piix.  
> > > 
> > >    It wasn't on purpose -- the IDE driver supports the original PIIX
> > > incorrectly.
> > >   
> > 
> > Hello
> > 
> > What about removing this old driver totally if it dont work ?
> 
> If the virtual Sparc emulator is using it does that also mean actual
> Sparc hardware has it. In which case presumably it needs fixing, or at
> least moving to the generic driver assuming the firmware sets it up ?
> 

The qemu works perfectly with the new Linux driver.