linux-kernel - Re: [PATCH] kernel/trace/trace_probe.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190312110044.6fb0e52b@gandalf.local.home>
Date:   Tue, 12 Mar 2019 11:00:44 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     "Valdis Klētnieks" <valdis.kletnieks@...edu>
Cc:     Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel/trace/trace_probe.c - make variable static

On Tue, 12 Mar 2019 04:52:58 -0400
"Valdis Klētnieks" <valdis.kletnieks@...edu> wrote:

> sparse complains:
>   CHECK   kernel/trace/trace_probe.c
> kernel/trace/trace_probe.c:16:12: warning: symbol 'reserved_field_names' was not declared. Should it be static?
> 
> Yes, it should be static.

Thanks, applied.

Note, I changed the subject to:

  tracing/probes: Make reserved_field_names static

To follow the naming convention of the tracing directory.

-- Steve


> 
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@...edu>
> 
> diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
> index 89da34b326e3..cfcf77e6fb19 100644
> --- a/kernel/trace/trace_probe.c
> +++ b/kernel/trace/trace_probe.c
> @@ -13,7 +13,7 @@
>  
>  #include "trace_probe.h"
>  
> -const char *reserved_field_names[] = {
> +static const char *reserved_field_names[] = {
>  	"common_type",
>  	"common_flags",
>  	"common_preempt_count",