linux-kernel - Re: [RFC PATCH v3 3/5] tracing: Use tracing error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1552409455.4293.24.camel@kernel.org>
Date:   Tue, 12 Mar 2019 11:50:55 -0500
From:   Tom Zanussi <zanussi@...nel.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     rostedt@...dmis.org, tglx@...utronix.de, namhyung@...nel.org,
        bigeasy@...utronix.de, joel@...lfernandes.org,
        linux-kernel@...r.kernel.org, linux-rt-users@...r.kernel.org
Subject: Re: [RFC PATCH v3 3/5] tracing: Use tracing error_log with hist
 triggers

Hi Masami,

On Wed, 2019-03-13 at 00:46 +0900, Masami Hiramatsu wrote:
> On Mon,  4 Mar 2019 17:36:46 -0600
> Tom Zanussi <zanussi@...nel.org> wrote:
> 
> > From: Tom Zanussi <tom.zanussi@...ux.intel.com>
> > 
> > Replace hist_err() and hist_err_event() with tracing_log_err() from
> > the new tracing error_log mechanism.
> > 
> > Also add a couple related helper functions and remove most of the
> > old
> > hist_err()-related code.
> > 
> > With this change, users no longer read the hist files for hist
> > trigger
> > error information, but instead look at tracing/error_log for the
> > same
> > information.
> 
> Could you also add a patch which update its testcase?
>  
> test.d/trigger/inter-event/trigger-extended-error-support.tc
> 
> will fail after this patch.
> 

Yeah, good point, will do (and documentation too).

Thanks,

Tom