linux-kernel - Re: [PATCH] mtd: physmap_of_gemini: remove extranous _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYeyaahQfE=uKVZQRwJGrhTZqAPHhq9yXEB7pFgwJ8-OA@mail.gmail.com>
Date:   Wed, 13 Mar 2019 22:22:49 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Boris Brezillon <bbrezillon@...nel.org>,
        Marek Vasut <marek.vasut@...il.com>,
        Richard Weinberger <richard@....at>,
        Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>,
        linux-mtd@...ts.infradead.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtd: physmap_of_gemini: remove extranous __xipram annotation

On Wed, Mar 13, 2019 at 10:19 PM Arnd Bergmann <arnd@...db.de> wrote:

> Marking a local variable as __xipram causes a warning because of the
> noinline attribute:
>
> drivers/mtd/maps/physmap-gemini.c:89:11: error: '__noinline__' attribute only applies to functions [-Werror,-Wignored-attributes]
>         map_word __xipram ret;
>                  ^
> include/linux/mtd/xip.h:34:18: note: expanded from macro '__xipram'
>  #define __xipram noinline __attribute__ ((__section__ (".xiptext")))
>
> I can't see any reason for the anotation anyway, so just remove it here.
>
> Fixes: 9d3b5086f6d4 ("mtd: physmap_of_gemini: Handle pin control")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij