linux-kernel - Re: [PATCH] [CIFS] Remove unneeded statements pointed out by Coverity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAN05THR2MpsVC9LwDfFDPA4nD9VWjKeF25Nsi2vJ=gC6=mNqVQ@mail.gmail.com>
Date:   Thu, 14 Mar 2019 08:14:21 +1000
From:   ronnie sahlberg <ronniesahlberg@...il.com>
To:     Steve French <smfrench@...il.com>
Cc:     CIFS <linux-cifs@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [CIFS] Remove unneeded statements pointed out by Coverity

reviewed by me

On Thu, Mar 14, 2019 at 7:53 AM Steve French <smfrench@...il.com> wrote:
>
> cifs: remove unused value pointed out by Coverity
>
> Detected by CoverityScan CID#1438719 ("Unused Value")
>
> buf is reset again before being used so these two lines of code
> are useless.
>
> Signed-off-by: Steve French <stfrench@...rosoft.com>
> ---
>  fs/cifs/connect.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index b95db2b593cb..a8e9738db691 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -1191,10 +1191,6 @@ cifs_demultiplex_thread(void *p)
>              continue;
>          }
>
> -        if (server->large_buf)
> -            buf = server->bigbuf;
> -
> -
>          server->lstrp = jiffies;
>
>          for (i = 0; i < num_mids; i++) {
>
> --
> Thanks,
>
> Steve